Treat bindless images handle types as native handles #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
callumfare
force-pushed
the
callum/bindless_workaround
branch
2 times, most recently
from
6d31e76
to
6a8ad56
Compare
callumfare
force-pushed
the
callum/bindless_workaround
branch
from
6a8ad56
to
be6d44d
Compare
callumfare
force-pushed
the
callum/bindless_workaround
branch
from
be6d44d
to
fe7c719
Compare
|
intel/llvm PR - intel/llvm#14516 |
przemektmalon
approved these changes
Jul 10, 2024
kbenzie
approved these changes
Jul 10, 2024
DBDuncan
approved these changes
Jul 10, 2024
callumfare
force-pushed
the
callum/bindless_workaround
branch
from
fe7c719
to
199287b
Compare
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Jul 11, 2024
…4516) oneapi-src/unified-runtime#1829 --------- Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bindless image extension added new handle types, however some of them are used in the SYCL Runtime in ways that contradict how handles are expected to be implemented, by casting them directly between other types. This breaks when UR is used with the UR loader, which transparently wraps handles to allow dispatching to specific adapters. This usage implies they are more like native handles, so they should be implemented like native handles.
Rename the image and image_mem types - if they end in
native_handle_t, they are treated as native handles. Also update ImageGetInfoExp to take a context handle so it still possible for the loader to dispatch to the adapters.Also fix incorrect return condition for
UR_RESULT_ERROR_INVALID_IMAGE_FORMAT_DESCRIPTORin bindless image functions